[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Device instability, gettext and default

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: Device instability, gettext and default
Date: Sat, 03 Mar 2012 21:04:03 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0

On 03.03.2012 20:48, Andreas Vogel wrote:
I was thinking about your proposal again and I think your idea
introducing a --id option is better than my idea having a --label option.

=== modified file 'include/grub/menu.h'
--- include/grub/menu.h 2011-01-10 22:27:58 +0000
+++ include/grub/menu.h 2012-03-03 12:11:30 +0000
@@ -32,6 +32,9 @@
    /* The title name.  */
    const char *title;

+  /* The identifier.  */
+  const char *id;
    /* If set means not everybody is allowed to boot this entry.  */
    int restricted;

Why are all the string variables declared as "const char *"? In my
opinion the const qualifier is not useful/needed.
This string is used for quite long time in different functions and the small corruption can lead to difficult to trace bugs. With const compiler takes care of checking them.

Grub-devel mailing list

Vladimir 'φ-coder/phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]