[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] verify: search keyid in hashed signature subpackets

From: Ignat Korchagin
Subject: Re: [PATCH] verify: search keyid in hashed signature subpackets
Date: Sun, 10 Apr 2016 19:34:58 +0100

> TBH I still think that simply setting READBUF_SIZE to 64K is the simplest 
> solution.

I would agree, but I was just a little concerned about allocating
large buffer. I'm not sure whether GRUB is considered to be able to
run on very resource constrained environments and it seemed that
per-subpacket allocation is better. But if you are sure it is OK for
64K buffer I can rewrite the code to allocate it once before using it.

> Just sign files and send new signatures and keys, I will commit them.

Will send with updated patch.

> This does more than just searching for keyid, it also hashes content, so name 
> is misleading.

Any suggestions?

> So you allocate full subpacket length anyway. Why not set READBUF_SIZE to max 
> size then from the very start?

See the comment about large buffer. This does per-subpacket
allocation, which should be less then overall subpacket length.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]