Re: [PATCH 05/10] efi/console: Implement getkeystatus() support

[Daniel Kiper]

On Fri, Mar 13, 2020 at 08:14:05PM +0100, Javier Martinez Canillas wrote:
> From: Hans de Goede <address@hidden>
>
> Implement getkeystatus() support.

This commit misses explanation why this patch is needed.

> Note that if a non-modifier key gets pressed and repeated calls to
> getkeystatus() are made then it will return the modifier status at the
> time of the non-modifier key, until that key-press gets consumed by a
> getkey() call.
>
> This is a side-effect of how the EFI simple-text-input protocol works
> and cannot be avoided.
>
> Signed-off-by: Hans de Goede <address@hidden>
> Signed-off-by: Javier Martinez Canillas <address@hidden>
>
> ---
>
>  grub-core/term/efi/console.c | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/grub-core/term/efi/console.c b/grub-core/term/efi/console.c
> index 11f85e84790..0e909c30ae1 100644
> --- a/grub-core/term/efi/console.c
> +++ b/grub-core/term/efi/console.c
> @@ -293,6 +293,39 @@ grub_console_getkey_ex(struct grub_term_input *term)
>    return key;
>  }
>
> +static int
> +grub_console_getkeystatus(struct grub_term_input *term)

Missing space after function name...

Otherise you can add Reviewed-by: Daniel Kiper <address@hidden>

Daniel