Re: [PATCH] btrfs: disable zstd support for i386-pc

[Mike Gilbert]

On Thu, Jun 11, 2020 at 6:58 PM Eli Schwartz <eschwartz@archlinux.org> wrote:
>
> On 11/7/19 12:08 AM, Vladimir 'phcoder' Serbinenko wrote:
> > On Wed, 6 Nov 2019, 20:55 Michael Chang, <MChang@suse.com> wrote:
> >
> >> On Wed, Nov 06, 2019 at 11:15:04AM -0800, Vladimir 'phcoder' Serbinenko
> >> wrote:
> >>> Please don't do it this way. The right solution is to move it to separate
> >>> module and include zstd module when needed.
> >>
> >> I fully agree to work out a proper solution, but before that I think it
> >> is necessary to stop it from spread out going forward, as the running
> >> system upgrading to new version could be affected and the consequence is
> >> fatal - an unbootable system, qualified to be show stopper imho.
> >>
> > We don't do a release right now, so I don't think it's justified. Also
> > increase in size can easily come from a compiler. If an increase in size
> > can make system unbootable on upgrade, I'd rather be fixing this than just
> > pepper over it.
>
> Given grub 2.06 is on the horizon, is it time to re-evaluate this and
> disable something known to be badly broken?

If I have read the thread correctly, this only breaks if you try to
install grub in an undersized embedding area. This would really only
affect new grub installs; existing ones can keep using the currently
installed code.

I think it would be better to hold out for a real fix than to disable
a feature for an entire platform where only a subset of configurations
would not work.