[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] btrfs: disable zstd support for i386-pc

From: Mike Gilbert
Subject: Re: [PATCH] btrfs: disable zstd support for i386-pc
Date: Tue, 23 Jun 2020 13:50:34 -0400

On Tue, Jun 23, 2020 at 2:32 AM Michael Chang <> wrote:
> On Mon, Jun 22, 2020 at 10:16:49PM -0400, Mike Gilbert wrote:
> > On Sun, Jun 21, 2020 at 2:56 PM Eli Schwartz <> 
> > wrote:
> > > But anyway this isn't true. There are valid reasons to reinstall grub on
> > > old systems, in which case you are most likely not benefiting from zstd
> > > support one way or another, but in this case, rerunning grub-install
> > > destroys the working bootloader code and fails to replace.
> >
> > This sounds like a bug/defect in grub-install. Ideally, it would look
> > at the size of the embedding area, and abort early if it is too small.
> > This should happen before files are copied to /boot/grub, but
> > currently it is done afterward.
> Even though the system can stay bootable, it cannot receive any grub
> updates afterward, thus breaking the principle of backward compatibilty
> that new build couldn't run at all on an existing system running old
> grub.

There was some discussion earlier in the thread that proposed the
documentation be updated to indicate that using a small embedding area
is not well-supported.

I don't think 100% backward compatibility is a reasonable target,
especially for configurations that have never been well-supported in
the first place.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]