[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeou

From: Javier Martinez Canillas
Subject: Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts
Date: Wed, 9 Sep 2020 12:47:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

Hello Daniel,

Thanks for the review.

On 9/7/20 9:36 PM, Daniel Kiper wrote:
> On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote:
>> Commit 781b3e5efc3 ("tftp: Do not use priority queue") caused a regression
> Please drop the quotes.

Sure, I can do that but I wonder why you don't want the quotes.
That's the convention used in many other projects.


>> Fixes: 781b3e5efc3 ("tftp: Do not use priority queue")
> Please drop this line.

Same question here. I think is important information, specially for
downstream since they could allow people to decide whether they need
to backport this patch or not.


>> +       */
>> +      if (grub_be_to_cpu16 (tftph-> < ((data->block + 1) & 
>>      ack (data, grub_be_to_cpu16 (tftph->;
>>        /* Ignore unexpected block. */
>>        else if (grub_be_to_cpu16 (tftph-> > data->block + 1)
> I think the fix is incomplete. You should change the line above too.

True, thanks for pointing it out.
> However, why do not do "((grub_uint16_t) (data->block + 1))" instead of
> "& BLK_MASK" in general?

Indeed. I'll change that and post a v2.

Best regards,
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]