[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeou

From: Javier Martinez Canillas
Subject: Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts
Date: Thu, 10 Sep 2020 12:07:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 9/10/20 12:00 AM, Alexey Makhalov wrote:


>>>>> Fixes: 781b3e5efc3 ("tftp: Do not use priority queue")
>>>> Please drop this line.
>>> Same question here. I think is important information, specially for
>>> downstream since they could allow people to decide whether they need
>>> to backport this patch or not.
>> You duplicate the information which is above. Additionally, IMO "Fixes:"
>> should contain bug number, CVE number, link to the bug, etc. not the
>> commit id.
> I think “Fixes: commit id” should remain in place. It provides direct 
> information
> from what commit the bug existed in case of regression.

Yes, I think the same. For example I usually do git log --grep="Fixes:", but
don't have a strong opinion and I'm OK with dropping it if Daniel prefer that.

Best regards,
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]