[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revise GC asserts.

From: Ludovic Courtès
Subject: Re: [PATCH] Revise GC asserts.
Date: Wed, 10 Sep 2008 09:32:21 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)


Han-Wen Nienhuys <address@hidden> writes:

> * libguile/gc.c (scm_i_gc): Change assert into deprecation warning.

Why?  It's not a deprecation but really an invariant, right?

> * libguile/private-gc.h (nil): introduce scm_i_last_marked_cell_count,
>   as a private mechanism for maintaining cell counts.  Previous
>   versions incremented scm_cells_allocated in an inlined function, so
>   loading dynamic objects of older GUILEs would break invariants.

OTOH, if we are to change the way `scm_cells_allocated' is used and
don't want older code to interfere with that, it's safe the break the
ABI here (we're on `master' after all).

Thus I would vote in favor of making `scm_cells_allocated' internal
(which requires that no public macro or inline function refer to it) or
renaming it, e.g., to `scm_i_cells_allocated'.

BTW, can you add a one-line summary to the log, as is done on `master',
`vm', etc.?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]