[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Revise GC asserts.

From: Han-Wen Nienhuys
Subject: Re: [PATCH] Revise GC asserts.
Date: Thu, 11 Sep 2008 03:21:49 -0300
User-agent: Thunderbird (X11/20080723)

Ludovic Courtès escreveu:
>> * libguile/gc.c (scm_i_gc): Change assert into deprecation warning.
> Why?  It's not a deprecation but really an invariant, right?

Yes, but it probably does not warrant crashing the program; memory 
allocation sizes will just be a bit off as a result.

> Thus I would vote in favor of making `scm_cells_allocated' internal
> (which requires that no public macro or inline function refer to it) or
> renaming it, e.g., to `scm_i_cells_allocated'.

Let's just remove the variable, since scm_i_last_marked_cell_count is a
more exact name.

> BTW, can you add a one-line summary to the log, as is done on `master',
> `vm', etc.?

The custom is (see git-format-patch) that the subject line is the summary.

 Han-Wen Nienhuys - address@hidden -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]