[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Colorized REPL

From: Nala Ginrut
Subject: Re: [PATCH] Colorized REPL
Date: Sat, 12 Jan 2013 17:59:40 +0800

hi Daniel & Ludo!

** Here are the changes:
1. Use srfi-9 record & fields comment
But I still like r6rs record, since it's less code to write. The only
good point for me is easy to comment each field. ;-P

2. Fix function define convention
I'm not aware of that, but are we going to define a function without
explicit 'lambda'?
Sorry but I didn't find any doc for this convention. I read HACKING
file, but it explains only about C code convention.
Anyway, I fixed it.

3. Rename "data" to "obj"

4. Fixed recursive REPL issue:
I think '(null? (fluid-ref *repl-stack*))' is true if there's no REPL
started, right?

** But suspended issues:
1. Code style issue
I can't find a doc in Guile for that. Could anyone help me out?

2. Array efficient issue
I'd like to fix it, but it's complex & inefficient either anyway.
I've no idea at all. Even if I simply output (object->string array),
it's inefficient as read it's array-prefix-part-string, and parse it.
The best way I think is to use array-rank/array-type... such things to
handle all the prefix-part of array. But as I said, it's too
complicated, the simplest way is the way I choose. 
My vote is to avoid complex design if unnecessary. But we may enhance it
later in the long term, rather than put all hackers' power to focus on a
rarely considered issue now.
What do you think?

3. Test case & manual
Should be done after all issues gone.
Anything missing?


Attachment: colorized.scm
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]