[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] split linker out of elf module
|
From: |
Andy Wingo |
|
Subject: |
Re: [PATCH 1/6] split linker out of elf module |
|
Date: |
Thu, 23 May 2013 09:26:31 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
On Wed 22 May 2013 22:39, address@hidden (Ludovic Courtès) writes:
> Looks good. Would be nice to mention variable names too.
Will do.
> It seems elf.scm would benefit from byte structures similar to those
> announced by Taylan on guile-user. That’s more for aesthetics though,
> and definitely not blocking.
Yes, but it's tricky. On-disk you can be 32-bit or 64-bit, and with
differing endiannesses. Makes it tricky to read. And on the writing
side you have the same, but also that you usually start from Scheme data
instead of bytevectors. I'm sure there is some useful abstraction
lurking there, but I haven't found it yet.
> Docstrings are lacking in those files.
Will fix.
Andy
--
http://wingolog.org/
- Re: [PATCH 5/6] refactor and simplify ELF loader in objcodes.c, (continued)
[PATCH 3/6] elf: add accessors for header members that might need relocation, Andy Wingo, 2013/05/18
[PATCH 4/6] refactor linker to lay out ELF files and memory in the same way, Andy Wingo, 2013/05/18
[PATCH 1/6] split linker out of elf module, Andy Wingo, 2013/05/18
Re: wip-linker: Refactor ELF linker and loader, Ludovic Courtès, 2013/05/22