[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

From: Alex Kost
Subject: Re: ui: Move 'show-manifest-transaction' from (guix profiles).
Date: Fri, 10 Oct 2014 11:00:48 +0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Ludovic Courtès (2014-10-10 02:08 +0400) wrote:

> address@hidden (Ludovic Courtès) skribis:
>> There’s:
>>   (guix store) -> (guix nar) -> (guix ui) -> (guix store) ...
> Commit 0363991 fixes that.
> (Now we must make sure we don’t reintroduce cycles in these modules;
> probably we should integrate Mark’s cycle detection script somehow.)
> With that I was able to apply the patch you posted.
> Thanks, and sorry for the mess!

Thank you for fixing that and sorry that I didn't reply to you on #guix
yesterday (I was away).

Now there shouldn't be problems with adding new condition types to (guix
profiles).  The patch is attached and “make check” was successful on
that.  2 little questions:

1. As you suggested I made a hierarchy of conditions:

> This is bikeshedding, but I would make a hierarchy like this:
>                      &profile-error, with ‘profile’ field
>                             ^
>            .———————————————–+———————————————–.
>            |                                 |
>   &profile-not-found-error        &missing-generation-error, with 
> ‘generation’ field

Thank you for the idea btw, I like it.  So the question is: should the
parent &profile-error be handled as well?  If yes, what message to use?

2. And another question: the current error for generation would look
like this:

  generation 18 does not exist

Is it OK or should I use ‘generation-file-name’ there and make it:

  generation '/some/path/to/profile/generation-18-link' does not exist

The problem now is I can't add ‘switch-to-generation’ procedure to (guix
profiles) as it uses ‘_’ and ‘switch-symlinks’ from (guix ui) which is
not “#:use-module”-ed anymore.  This patch is also attached.  What to do
about it?  I think moving ‘switch-to-generation’ to (guix ui) is not
good or is it?  Perhaps it would be better to move ‘switch-symlinks’ and
all ‘_’, ‘N_’, … stuff to (guix utils)?  But what do I know, it's up to
you again (I feel guilty that I have to bother you again).

Attachment: 0001-profiles-Add-condition-types-for-profiles-and-genera.patch
Description: Text Data

Attachment: 0002-profiles-Add-procedures-for-switching-generations.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]