[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ui: Move 'show-manifest-transaction' from (guix profiles).

From: Alex Kost
Subject: Re: ui: Move 'show-manifest-transaction' from (guix profiles).
Date: Fri, 10 Oct 2014 19:20:47 +0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Ludovic Courtès (2014-10-10 16:15 +0400) wrote:

> Alex Kost <address@hidden> skribis:
>> Ludovic Courtès (2014-10-10 02:08 +0400) wrote:
> [...]
>>> This is bikeshedding, but I would make a hierarchy like this:
>>>                      &profile-error, with ‘profile’ field
>>>                             ^
>>>            .———————————————–+———————————————–.
>>>            |                                 |
>>>   &profile-not-found-error        &missing-generation-error, with 
>>> ‘generation’ field
>> Thank you for the idea btw, I like it.  So the question is: should the
>> parent &profile-error be handled as well?  If yes, what message to use?
> Let’s ignore it for now, it Shouldn’t Happen™.

OK, that's what I thought.

>> 2. And another question: the current error for generation would look
>> like this:
>>   generation 18 does not exist
>> Is it OK or should I use ‘generation-file-name’ there and make it:
>>   generation '/some/path/to/profile/generation-18-link' does not exist
> I prefer “generation 18 does not exist”, or maybe “generation 18 of
> ‘/some/profile’ does not exist”.  WDYT?

I agree, mentioning a profile would be better.  I modified the patch for

>> The problem now is I can't add ‘switch-to-generation’ procedure to (guix
>> profiles) as it uses ‘_’ and ‘switch-symlinks’ from (guix ui) which is
>> not “#:use-module”-ed anymore.  This patch is also attached.  What to do
>> about it?  I think moving ‘switch-to-generation’ to (guix ui) is not
>> good or is it?
> Yeah, a you suggested on IRC, let’s just leave it in (guix scripts
> package) until we have a better idea.  :-)

OK, I have not pushed anything yet, as the commits were changed a bit.
I'm attaching all 3 patches for adding “Switch to generation” support.
Everything seems OK now (at least “make check” does not fail anymore),
so if you don't have final comments, I would like to commit them.
Thanks for the patience.

Attachment: 0001-profiles-Add-condition-types-for-profiles-and-genera.patch
Description: Text Data

Attachment: 0002-profiles-Add-relative-generation.patch
Description: Text Data

Attachment: 0003-guix-package-Add-switch-generation-option.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]