[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Texinfo in descriptions?

From: Mathieu Lirzin
Subject: Re: Texinfo in descriptions?
Date: Sun, 30 Aug 2015 22:42:46 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Here is an updated patch.

address@hidden (Ludovic Courtès) writes:

> Mathieu Lirzin <address@hidden> skribis:
>> From e98c0ec3b609c077bf471cf838f12f54a89a0226 Mon Sep 17 00:00:00 2001
>> From: Mathieu Lirzin <address@hidden>
>> Date: Fri, 7 Aug 2015 00:10:43 +0200
>> Subject: [PATCH] packages: Add package-description-string.
>> * guix/packages.scm (package-description-string): New variable.
>> * guix/utils.scm (texi->plain-text): Likewise.
>> * guix/ui.scm (package->recutils): Use it.
>> * gnu/packages/perl.scm (perl-devel-globaldestruction)
>>   (perl-devel-lexalias, perl-exporter-lite): Adapt to Texinfo's markup.
>> * gnu/packages/python.scm (python2-empy): Likewise.
> We must also make sure that the Emacs UI (and guix-web, but that’s a
> different repo) use ‘package-description-string’ instead of
> ‘package-description’.
> For Emacs, I think it’s enough to
> s/package-description/package-description-string/ in guix-main.scm.
> Alex?


>>  5 files changed, 20 insertions(+), 5 deletions(-)
> I like that it’s all it takes.  :-)

5 files changed, 18 insertions(+), 11 deletions(-)
Can you say less?! :)

> Any performance figures?  For instance, time of ‘guix package -s’ before
> and after?

With the updated patch I have obtained the following results for command

  time ./pre-inst-env guix package -s e

- without patch:
real    0m25.381s
user    0m8.740s
sys     0m0.184s

- with patch:
real    0m24.556s
user    0m10.448s
sys     0m0.220s

This test has revealed one missing modification for "perl-dbd-pg"
package description.

> What about moving ‘package-description-string’ to (guix ui) and have it
> do both rendering and translation?
> If an application really needs rendered-but-not-translated stuff, it can
> always use (compose texi-fragment->text package-description); I think
> that’d be an unusual use case anyway.

Yeah that's a nice minimal solution! Thanks.

Attachment: 0001-ui-Add-package-description-string.patch
Description: Text Data

And for the website.

Attachment: 0001-website-packages-Support-Texinfo-s-markup.patch
Description: Text Data

Mathieu Lirzin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]