[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Gracefully handle incompatible locale data

From: Carlos O'Donell
Subject: Re: [PATCH] Gracefully handle incompatible locale data
Date: Mon, 28 Sep 2015 16:54:01 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 09/26/2015 06:24 AM, Ludovic Courtès wrote:
> Furthermore, the function in question returns EINVAL in other similar
> cases–e.g., when libc 2.22 loads LC_COLLATE data from libc 2.21.

If you change this particular case to EINVAL, what does the user see
as a result of this change? Do they get a non-zero exit code from
`localedef --list-archive` along with an error written out to stderr?

This is the kind of change I'm expecting. If we are removing an assertion,
we should be replacing it with something meaningful and verifying that
meaningful change.

You need not change any of the other cases you've found that return EINVAL,
we can update those incrementally, but for this one change you're making
we should fix it as best we can.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]