[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] Add hplip
From: |
Andy Wingo |
Subject: |
Re: [PATCH v3] Add hplip |
Date: |
Tue, 22 Mar 2016 11:56:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi,
Looking better, thank you! A couple of style nits and a tip.
On Tue 22 Mar 2016 11:30, Danny Milosavljevic <address@hidden> writes:
> + (description "Hewlett-Packard Printer Drivers and PPDs.")
> + (license (list license:gpl2 license:bsd-3)) ; FIXME and which MIT
> + ; FIXME remove proprietary plug-in installer, hp-plugin (plugin.py)
> + ; FIXME PPDs use "hpcups" in cupsFilter. In which directory?
> + ; TODO install apparmor profile files
Comments that align with the expression on the next line should start
with ";;". This kind of comment should be full sentences. Good to
leave in a note about AppArmor I guess, though it's not a current thing
in Guix. See other packages for examples of how to delete files.
> + (arguments `(#:configure-flags `("--disable-network-build"
> + ,(string-append "--prefix="
This sort of thing is more usually indented as:
(arguments
`(#:configure-flags
`("--disable-network-build"
(string-append "--prefix=" ...)
...)
#:phases
...))
> + #:phases (alist-cons-after 'fix-libusb 'autoreconf
Please use modify-phases instead of alist-cons-after.
> + ; I don't think we need to propagate those.
> + ; wrapper: makes "python" available rather than "python3"
No need to leave in these comments, IMO.
> + ("python-wrapper" ,python-wrapper)
> + ("python" ,python) ; patch-shebang still complains
> + ; TODO: make hp-setup find python-dbus
> + ("python-dbus" ,python-dbus)))
> + ;(propagated-inputs `(("python" ,python)
> + ; ("python-dbus" ,python-dbus)))
You can probably can remove this too.
Cheers,
Andy
- Using cups, Danny Milosavljevic, 2016/03/12
- Re: Using cups, Ludovic Courtès, 2016/03/13
- Re: Using cups, Danny Milosavljevic, 2016/03/15
- hplip package (work in progress), Danny Milosavljevic, 2016/03/15
- Re: hplip package (work in progress), Andy Wingo, 2016/03/16
- Re: hplip package (work in progress), Andy Wingo, 2016/03/16
- Re: hplip package (work in progress), Danny Milosavljevic, 2016/03/19
- [PATCH v2] Add hplip, Danny Milosavljevic, 2016/03/21
- Re: [PATCH v2] Add hplip, Andy Wingo, 2016/03/22
- [PATCH v3] Add hplip, Danny Milosavljevic, 2016/03/22
- Re: [PATCH v3] Add hplip,
Andy Wingo <=
- [PATCH v4] Add hplip, Danny Milosavljevic, 2016/03/22
- cups-service, Danny Milosavljevic, 2016/03/22
- Re: cups-service, Danny Milosavljevic, 2016/03/22
- cups-service v2, Danny Milosavljevic, 2016/03/23
- Re: [PATCH v4] Add hplip, Andy Wingo, 2016/03/23
- [PATCH v5] Add hplip, Danny Milosavljevic, 2016/03/23
- [PATCH v6] Add hplip, Danny Milosavljevic, 2016/03/23
- Re: [PATCH v6] Add hplip, Efraim Flashner, 2016/03/23
- [PATCH v7] Add hplip, Danny Milosavljevic, 2016/03/23