[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/8] gnu: qt: Update to 5.6.1-1.

From: Ludovic Courtès
Subject: Re: [PATCH 1/8] gnu: qt: Update to 5.6.1-1.
Date: Fri, 29 Jul 2016 21:20:48 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

David Craven <address@hidden> skribis:

> * gnu/packages/qt.scm (qt): Update to 5.6.1-1.

I think there are 3 patches here: the update, the switch to
‘modify-phases’, and the thing that disables examples.  Could you
separate them?

> +       (modify-phases %standard-phases
> +         (add-after 'configure 'patch-bin-sh
> +           (lambda _
> +             (substitute* '("qtbase/config.status"
> +                            "qtbase/configure"
> +                            "qtbase/mkspecs/features/qt_functions.prf"
> +                            "qtbase/qmake/library/qmakebuiltins.cpp")
> +                          (("/bin/sh") (which "sh")))
This should be aligned with the ‘u’ of ‘substitute*’.

It seems like these substitutions could be added to the existing ones
int the ‘configure’ phase.

Otherwise LGTM.

Could you send updated patches?

Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]