Re: [PATCH 1/2] gnu: Add r-bit.

[Ricardo Wurmus]

Hi Ben,

thanks for the patch!

> * gnu/packages/statistics.scm (r-bit): New variable.
> ---
>  gnu/packages/statistics.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 36f1889ef..ea9ef0e39 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -205,6 +205,29 @@ publication-quality data plots.  A large amount of 
> 3rd-party packages are
>  available, greatly increasing its breadth and scope.")
>      (license license:gpl3+)))
>  
> +(define-public r-bit
> +  (package
> +    (name "r-bit")
> +    (version "1.1-12")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "bit" version))
> +       (sha256
> +        (base32
> +         "0a6ig6nnjzq80r2ll4hc74za3xwzbzig6wlyb4dby0knzf3iqa6f"))))
> +    (build-system r-build-system)
> +    (home-page "http://ff.r-forge.r-project.org";)
> +    (synopsis "A class for vectors of 1-bit booleans")

Without “A” please.  Just “Class for vectors …”.

> +    (description
> +     "This package provides bitmapped vectors of booleans (no NAs), coercion
> +from and to logicals, integers and integer subscripts; fast boolean operators
> +and fast summary statistics.  With 'bit' vectors true binary booleans

“With *the @code{bit} class* vectors *of* true binary booleans …”

> +{FALSE,TRUE} can be stored with 1 bit only, on a 32 bit architecture this
> +means factor of 32 less RAM and a factor of 32 more speed on boolean
> +operations.")

I’d leave off “, on a 32 bit architecure …”.  If you want to keep it,
though, I’d suggest making this a separate full sentence (or at least
separate them with a semicolon).

> +    (license license:gpl2)))
> +
>  (define-public r-colorspace
>    (package
>      (name "r-colorspace")

Pity it’s GPL2 only, but this seems to be correct (there are even
license headers with an explicit version).

Okay with these changes.  Thanks!

-- 
Ricardo
  
GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net