Re: [PATCH] gnu: Add ldc-1.1.0-beta4

[Danny Milosavljevic]

Hi,

On Wed, 4 Jan 2017 17:01:14 +0300
Frederick Muriithi <address@hidden> wrote:

> Added ldc-1.1.0-beta4 since all other beta versions from there seem to
> reuse the same phobos, druntime and dmd-testsuite.

Thanks for the patch!

Hmm, you added gdb to the native-inputs but commented out the gdb invocations 
later? Why?

Also, could you ask upsteam whether they add a version flag (or something) for 
the http tests? So it can be enabled/disabled without huge patches in the 
future...

Also, why did you comment out unzip? You can add "unzip" to native-inputs.

Also, why do you add another "patch-phobos" phase? I think the one in ldc, from 
which you inherit, does the same, no?

I think I had the same problem with tzNames before. I think one of the 
functions there doesn't interpret its argument as a relative path if it 
contains a slash anywhere, ruining your /gnu/store prefix or something. Please 
look into it.