[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add Xfce Notification Daemon.

From: Petter
Subject: Re: [PATCH] gnu: Add Xfce Notification Daemon.
Date: Mon, 24 Apr 2017 20:54:41 +0200

Hei Marius,

> > +    (native-inputs
> > +     `(("intltool" ,intltool)
> > +       ("pkg-config" ,pkg-config)))
> > +    (propagated-inputs
> > +     `(("glib:bin" ,glib "bin")))  
> Do you know why glib:bin needs to be propagated here? Looking at
> gnome.scm, it's usually a "native-input". If this program requires
> some of the executables from that package at runtime, it's better to
> patch it with the absolute paths.

I don't know. I just saw it done like this in another package in

Reading up on inputs I see propagated-inputs "will be installed
alongside the package they belong to". Yeah, let's see if we can avoid

I've adjusted the recipe to test with glib:bin as a native-input,
it builds fine, and a quick remove and install shows no issues either.
However, the notification system still worked with it removed, so I'm
not certain the new one is the one used. I will test this further next
time I boot my system.

> Other than that looks great! I'd add an @code{...} wrapper around
> "org.freedesktop.Notifications" in the description, but that can be
> fixed up before committing, no need for a new patch.

I'll make sure to add this if I produce a new patch.

Thanks for the feedback!


Attachment: pgpTk8UeciNKz.pgp
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]