Re: qtwenengine anybody?

[mike . rosset]

Pierre Neidhardt <address@hidden> writes:

> Fantastic, Marius!  Some nits below:
>
>>  ;;; Copyright © 2019 Marius Bakke <address@hidden>
>
> 2020 for Marius?
>
>> +       ;; FIXME: libxml2 needs to built with icu support though it links to
>> +       ;; libxml2 configure summary still states. Checking for compatible
>> +       ;; system libxml2... no
>
> Punctuation:
>
> ... still states "Checking for compatible system libxml2... no".
>
>
>> +       ;; Tests are disabled due to Could not find QtWebEngineProcess error
>> +       ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH
>> +       ;; before running tests It's also possible some tests need a network
>
> Punctuation:
>
> Test are disabled due to "Could not find QtWebEngineProcess" error.
> It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH
> before running tests.  It's also possible some tests need a network.

Will fix these ASAP, thanks for pointing theses out.

>> +             (define (third-party? file)
>> +               (if (string-contains file "third_party/")
>> +                   #t
>> +                   #f))
>
> Maybe just
>
> (define (third-party? file)
>   (string-contains file "third_party/"))
>
> ?

I have a patch to fix this will include it with punctuation.