Re: patch-shebang and Rust - Change on core-updates?

[Ludovic Courtès]

Hi,

Danny Milosavljevic <address@hidden> skribis:

> Rust uses #![...] for something that is definitely not a shebang
> (file-wide feature tests).
>
> Currently, our patch-shebang[1] emits a lot of warnings because of those.
>
> Should we change patch-shebang to ignore lines starting with "#![" ?
>
> If so, how?  There's some get-char* magic that I don't understand.
>
> The easiest way would be to add peek-char after the two calls to get-char*,
> but not sure if that would work.
>
> Alternatively, we could adapt the regexp.
>
>>(define patch-shebang
>>  (let ((shebang-rx (make-regexp 
>> "^[[:blank:]]*([[:graph:]]+)[[:blank:]]*([[:graph:]]*)(.*)$")))
>
> The [[:graph:]]+ would have to change to something like 
>
>   [[:graph-without-opening-bracket:]][[:graph:]]+

Or rather: /[[:graph:]]+ ?

A real shebang has to be an absolute file name so it must start with a
slash.

If that works for you, I’d say it’s OK to do that on ‘core-updates’.

Thanks,
Ludo’.