[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Patched shebangs in Autoconf-provided scripts
From: |
Ludovic Courtès |
Subject: |
Patched shebangs in Autoconf-provided scripts |
Date: |
Tue, 31 Aug 2021 01:06:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi!
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> There was a problem where these files had embedded file names:
>
> guix-1.3.0rc2.5207-ce515/build-aux/config.guess:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
> guix-1.3.0rc2.5207-ce515/build-aux/config.sub:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
> guix-1.3.0rc2.5207-ce515/build-aux/install-sh:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
> error: store file names embedded in the distribution
>
> I had not seen this issue and it'll need to be investigated. For now I
> disabled the check to get the dist archive produced.
These three files are installed by ‘autoreconf -i’ (unless already
present), and I’m afraid our automake/autoconf packages ship them with
those shebangs:
--8<---------------cut here---------------start------------->8---
$ head -1 $(find $(guix build autoconf) -name config.guess)
#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
$ head -1 $(find $(guix build autoconf) -name config.sub)
#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
$ head -1 $(find $(guix build automake) -name install-sh)
#!/bin/sh
--8<---------------cut here---------------end--------------->8---
So automake is good thanks to its ‘unpatch-shebangs’ phase (maybe your
‘install-sh’ file predates that fix?), but autoconf is not. Reported!
Anyway, the simple solution is to manually edit those three files so
they read #!/bin/sh and you’ll be fine!
Ludo’.