Re: Patched shebangs in Autoconf-provided scripts

[Maxim Cournoyer]

Hi Ludo,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi!
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> There was a problem where these files had embedded file names:
>>
>> guix-1.3.0rc2.5207-ce515/build-aux/config.guess:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
>> guix-1.3.0rc2.5207-ce515/build-aux/config.sub:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
>> guix-1.3.0rc2.5207-ce515/build-aux/install-sh:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
>> error: store file names embedded in the distribution
>>
>> I had not seen this issue and it'll need to be investigated.  For now I
>> disabled the check to get the dist archive produced.
>
> These three files are installed by ‘autoreconf -i’ (unless already
> present), and I’m afraid our automake/autoconf packages ship them with
> those shebangs:
>
> $ head -1 $(find $(guix build autoconf) -name config.guess)
> #!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
> $ head -1 $(find $(guix build autoconf) -name config.sub)
> #!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh
> $ head -1 $(find $(guix build automake) -name install-sh)
> #!/bin/sh
>
> So automake is good thanks to its ‘unpatch-shebangs’ phase (maybe your
> ‘install-sh’ file predates that fix?), but autoconf is not.  Reported!

Thanks for reporting the issue :-).  It'll be one to fix before the
release.

> Anyway, the simple solution is to manually edit those three files so
> they read #!/bin/sh and you’ll be fine!

Yep, the purpose of the test here was simply producing a dist archive to
see what was in so it was not critical, but it'll come back in the
picture as soon as we enter release mode :-).

Thanks,

Maxim