[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorte
From: |
宋文武 |
Subject: |
[bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. |
Date: |
Sat, 08 Dec 2018 11:51:43 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Arun Isaac <address@hidden> writes:
> * guix/scripts/lint.scm (check-inputs-should-be-sorted): New procedure.
> (%checkers): Add it.
> [...]
>
> +(define (check-inputs-should-be-sorted package)
> + ;; Emit a warning if inputs, native inputs or propagated inputs of PACKAGE
> + ;; are not lexicographically ordered.
Hello, consider 'gspell', it has some native-inputs for build and some
for test:
(native-inputs
`(("glib" ,glib "bin")
("pkg-config" ,pkg-config)
("xmllint" ,libxml2)
;; For tests.
("aspell-dict-en" ,aspell-dict-en)
("xorg-server" ,xorg-server)))
Currently I'd seperated them by a comment like this.
If they are sorted, I have to add comment for each test input:
`(("aspell-dict-en", aspecll-dict-en) ; for test
("glib" ,glib "bin")
("pkg-config" ,pkg-config)
("xmllint" ,libxml2)
("xorg-server" ,xorg-server)) ; for test
Which will be a little annoying...