[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34128] [PATCH] add emacs built with xwidgets-support

From: Ludovic Courtès
Subject: [bug#34128] [PATCH] add emacs built with xwidgets-support
Date: Tue, 22 Jan 2019 22:48:26 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Arne,

Arne Babenhauserheide <address@hidden> skribis:

> * gnu/packages/emacs.scm (emacs-xwidgets): new variable

Thanks for the patch!  I wonder why this hadn’t been done before;
Nicolas, Alex, Pierre, thoughts?

The patch LGTM, minor stylistic issues:

> +(define-public emacs-xwidgets
> +  (package (inherit emacs)
> +           (name "emacs-xwidgets")
> +           (synopsis "The extensible, customizable, self-documenting text
> +editor (with xwidgets support)")
> +           (build-system gnu-build-system)
> +           (arguments (append
> +                       (package-arguments emacs)
> +                       `(#:configure-flags
> +                         '("--with-xwidgets"))))
> +           (inputs (append
> +                    (package-inputs emacs)
> +                    `(("webkitgtk" ,webkitgtk)
> +                      ("libxcomposite" ,libxcomposite))))))

Please indent rather along these lines (like in the rest of the file):

  (define-public emacs-xwidgets
      (inherit emacs)
      (name …) …))

Likewise, for consistency, use unquote-splicing rather than ‘append’:

  (inputs `(("webkitgtk" ,webkitgtk)
            ;; …
            ,@(package-inputs emacs)))

Could you send an updated patch?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]