[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34128] [PATCH] add emacs built with xwidgets-support
From: |
Arne Babenhauserheide |
Subject: |
[bug#34128] [PATCH] add emacs built with xwidgets-support |
Date: |
Wed, 23 Jan 2019 00:10:41 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Hi Ludovic,
> Thanks for the patch!
Thank you for your review!
> I wonder why this hadn’t been done before;
> Nicolas, Alex, Pierre, thoughts?
There is an older bug with xwidgets support which had problems because
it depended on an old version of webkitgtk (I only found it after I sent
the patch). Maybe that stopped others from submitting.
Ludovic Courtès <address@hidden> writes:
> The patch LGTM, minor stylistic issues:
> …
> Please indent rather along these lines (like in the rest of the file):
>
> (define-public emacs-xwidgets
> (package
> (inherit emacs)
> (name …) …))
>
> Likewise, for consistency, use unquote-splicing rather than ‘append’:
>
> (inputs `(("webkitgtk" ,webkitgtk)
> ;; …
> ,@(package-inputs emacs)))
>
> Could you send an updated patch?
Is inline here OK? If yes:
From ed2eca1ade73eb6b7c2e8b17541e3e182ade4608 Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide <address@hidden>
Date: Fri, 18 Jan 2019 23:29:14 +0100
Subject: [PATCH] add emacs built with xwidgets-support
* gnu/packages/emacs.scm (emacs-xwidgets): new variable
---
gnu/packages/emacs.scm | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a488289f1..7e8dcadf9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -59,6 +59,7 @@
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages texinfo)
#:use-module (gnu packages tls)
+ #:use-module (gnu packages webkit)
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg)
#:use-module (guix utils)
@@ -210,6 +211,22 @@ languages.")
(native-inputs
`(("pkg-config" ,pkg-config)))))
+(define-public emacs-xwidgets
+ (package
+ (inherit emacs)
+ (name "emacs-xwidgets")
+ (synopsis "The extensible, customizable, self-documenting text
+editor (with xwidgets support)")
+ (build-system gnu-build-system)
+ (arguments
+ `(#:configure-flags
+ '("--with-xwidgets")
+ ,@(package-arguments emacs)))
+ (inputs
+ `(("webkitgtk" ,webkitgtk)
+ ("libxcomposite" ,libxcomposite)
+ ,@(package-inputs emacs)))))
+
(define-public emacs-no-x
(package (inherit emacs)
(name "emacs-no-x")
--
2.19.2
Best wishes,
Arne
--
Unpolitisch sein
heißt politisch sein
ohne es zu merken
signature.asc
Description: PGP signature