[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34358] [PATCH] gnu: address@hidden: Honor NIX_STORE.

From: Caleb Ristvedt
Subject: [bug#34358] [PATCH] gnu: address@hidden: Honor NIX_STORE.
Date: Wed, 06 Feb 2019 18:07:21 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Ludovic Courtès <address@hidden> writes:

> Perhaps in the future you could email address@hidden for specific
> commits like this one, especially when it’s not strictly related to the
> daemon?


> Could you send an updated version of the patch?

Here it is!

> ./configure does not generate any patch files based on patch templates,
> and that’s on purpose.  Instead, when we need something like this, we
> handle it the way is handled: by doing the substitution
> when creating the derivation.

"When creating the derivation" sounds like it's when the package is lowered
to a derivation, but from what I can see of ld-wrapper in (gnu packages
base) the actual substitution is done when the derivation is built. I
am curious how one would go about doing the substitution when the
package is lowered to a derivation, though. Anyway, for now I'm doing
the substitution at derivation-build-time.

> Last, the patch would need to go to ‘core-updates’ because of the number
> of rebuilds it entails.

Should I mention this somewhere?

Also, I should add that "guix lint" and indent-code.el both want changes
to gnu/packages/python.scm, but not due to changes I made. Should a
separate patch address those?

- reepca

Attachment: 0001-gnu-python-2.7-Honor-NIX_STORE.patch
Description: gnu: python@2.7: Honor NIX_STORE.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]