[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42339: [PATCH core-updates] gnu: glibc-intermediate: Fixup the pre-c
bug#42339: [PATCH core-updates] gnu: glibc-intermediate: Fixup the pre-configure phase.
Fri, 24 Jul 2020 00:15:45 +0200
On Thu, Jul 23, 2020 at 09:49:17AM +0200, Ludovic Courtès wrote:
> Jakub Kądziołka <email@example.com> skribis:
> > On Thu, Jul 23, 2020 at 12:00:22AM +0200, Ludovic Courtès wrote:
> >> Hello,
> >> Jakub Kądziołka <firstname.lastname@example.org> skribis:
> >> > * gnu/packages/commencement.scm
> >> > (glibc-final-with-bootstrap-bash)[arguments]: Don't patch sunrpc,
> >> > as it's no longer required. Tweak C_INCLUDE_PATH and
> >> > CPLUS_INCLUDE_PATH instead of CPATH.
> >> > The debug output does not refer to a bootstrap glibc anymore whether the
> >> > phase
> >> > is there or not, though it does refer to gcc-cross-boot0:lib. Does this
> >> > mean that the phase is simply obsolete, and only the hurd parts should
> >> > remain, or is the reference to gcc a bug? Perhaps gcc should have a
> >> > separate output for the includes it provides (stdarg and such) so that
> >> > this reference doesn't bring in the whole mesboot tree? This would
> >> > improve the closure of gcc-toolchain:debug...
> >> Oooh, nice. LGTM!
> > Thanks for your review!
> >> Please confirm that nothing breaks (everything builds at least up to
> >> ‘gcc-final’) and you can push to ‘core-updates’.
> > I have confirmed that hello builds both natively and cross-built. On a
> > similar topic, the same test succeeded for removing the native-gcc input.
> > As the comment suggests, it was only being used for --enable-obsolete-rpc.
> > I am thus considering a v2 that also removes said input. Does that make
> > sense?
> Yes it does (again provided nothing breaks).
> Thank you!
Thanks, patches pushed!
Description: PGP signature