[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43194] [PATCH] gnu: publicly define freedink-engine and freedink-da
From: |
Ludovic Courtès |
Subject: |
[bug#43194] [PATCH] gnu: publicly define freedink-engine and freedink-data |
Date: |
Mon, 07 Sep 2020 15:46:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi,
Jesse Gibbons <jgibbons2357@gmail.com> skribis:
> The attached patch publicly defines freedink-engine and
> freedink-data. This resolves many of the issues described in
> #43061. This patch, combined with patch #43193(sent earlier today),
> can close #43061.
Now I’m confused: how does it help to make freedink-{engine,data}
public?
>>From 583215aced9b557d6f4e54b290e788d33880c03c Mon Sep 17 00:00:00 2001
> From: Jesse Gibbons <jgibbons2357+guix@gmail.com>
> Date: Wed, 26 Aug 2020 21:38:24 -0600
> Subject: [PATCH v1 1/1] gnu: publicly define freedink-engine and freedink-data
>
> * gnu/packages/games.scm: (freedink-engine): make public
> (freedink-data): make public
[...]
> (define-public freedink
> ;; This is a wrapper that tells the engine where to find the data.
> - (package (inherit freedink-engine)
> + (package ;(inherit freedink-engine)
Is it intended? Looks like inheriting avoids duplicating fields, no?
Thanks,
Ludo’.