[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43840] [PATCH] gnu: Add esbuild.

From: Efraim Flashner
Subject: [bug#43840] [PATCH] gnu: Add esbuild.
Date: Sun, 11 Oct 2020 13:28:53 +0300

On Thu, Oct 08, 2020 at 02:08:36AM +0000, Ryan Prior wrote:
> Hey Efraim, thank you for your comments!
> On Wednesday, October 7th, 2020 at 6:34 AM, Efraim Flashner 
> <> wrote:
> > There is an npm directory which is where the compiled binaries are
> > placed, there are a couple in the checked out repo.
> The compiled binaries might be placed there by the gnu-build-system, but the 
> go-build-system does not put binaries there by itself. (Note that their make 
> target explicitly specifies output directories.)
> I think our build totally ignores this directory, so it shouldn't matter 
> whether we delete it, but if you think removing the unneeded directory 
> improves the package I'll update the patch with a snippet.

It's important to not ship any precompiled binaries so go ahead and
remove them in a snippet.

> >     Is it worth trying to run some of the test suite? I see there are a
> >     couple of 'make check' type targets in the Makefile at the root of the
> >     repository and currently there are none run during the build.
> It would be nice to run their tests, but the test system currently assumes 
> network access to install some various JavaScript dependencies using npm. We 
> might patch the test system and vendor in the deps (used only for testing,) 
> what do you think?

I was able to run some of the test suite with the following arguments section:

 '(#:import-path ""
   #:unpack-path ""
   (modify-phases %standard-phases
     (replace 'check
       (lambda* (#:key tests? unpack-path #:allow-other-keys)
         (if tests?
           (with-directory-excursion (string-append "src/" unpack-path)
             (invoke "make" "test-go"))

Unfortunately it also depends on, but
it doesn't look like it has any dependants. With that added as a
native-input I think it's ready.

> Ryan


Efraim Flashner   <>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]