[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#44193] [PATCH 0/1] 'guix publish --cache' can publish items not yet

From: Ludovic Courtès
Subject: [bug#44193] [PATCH 0/1] 'guix publish --cache' can publish items not yet cached
Date: Sun, 25 Oct 2020 17:49:38 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)


Miguel Ángel Arruga Vivas <> skribis:

> Ludovic Courtès <> writes:
>> Thus, the first narinfo request for an item would always return 404;
>> one would have to wait until the item is baked to get 200 and download
>> the substitute.
> I'd argue that returning unconditionally the 404 is a problem.  If the
> nar is getting baked, I guess that a 202[1] would be the appropriate
> answer, and I'd leave the 404 for invalid store paths[2].  This way the
> client could implement more policies: the classic timeout, but also, for
> example, it might check other servers before checking once again if
> nobody else has it, or directly wait until a 404 is reached.  WDYT?

Indeed, 202 seems more appropriate (and it’s precisely half of 404, that
tells something!).

Unfortunately (guix scripts substitute) currently explicitly checks for
404 and 200 and considers anything else to be a transient error with a
default TTL (in ‘handle-narinfo-response’).  So we would need to adapt
that first and then wait until some time has passed before ‘guix
publish’ can return 202.  :-/

I guess we can change (guix scripts substitute) with that in mind
already.  WDYT?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]