guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47930] [PATCH] gnu: Add pbgzip.


From: Roel Janssen
Subject: [bug#47930] [PATCH] gnu: Add pbgzip.
Date: Thu, 29 Apr 2021 14:22:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/29/21 9:29 AM, Efraim Flashner wrote:
On Thu, Apr 22, 2021 at 06:40:46PM +0200, Maxime Devos wrote:
Xinglu Chen schreef op wo 21-04-2021 om 23:45 [+0200]:
On Wed, Apr 21 2021, Roel Janssen wrote:

[...]
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'autogen
+             (lambda _
+               (zero? (system* "sh" "autogen.sh")))))))
IIRC, phases don’t have to return #t, so you could remove ‘zero?’.
Try running (system* "does-not-exist").  It will fail by returning
something non-zero.  If I recall how to call "invoke" correctly,
I would recommend (invoke "sh" "autogen.sh") here.  "invoke" raises
an exception when the command fails, instead of returning something.
While we're at it, can this phase replace 'bootstrap? It seems to me we
shouldn't need both phases.
This indeed seems to be the best thing to do.  I attached a new patch.

I had to leave autoconf and automake in the native-inputs because
otherwise the command "aclocal" and "autom4te" couldn't be found.

Thanks all for the feedback!  I hope this new patch is fine.

Kind regards,
Roel Janssen

Attachment: 0001-gnu-Add-pbgzip.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]