[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] Fwd: PATCH1/2: byte code profiling for gst: recordi
From: |
Derek Zhou |
Subject: |
Re: [Help-smalltalk] Fwd: PATCH1/2: byte code profiling for gst: recording |
Date: |
Sun, 8 Feb 2009 18:50:51 -0800 |
User-agent: |
KMail/1.9.9 |
On Sunday 08 February 2009 02:29:29 pm Paolo Bonzini wrote:
> > --- a/kernel/CompiledBlk.st
> > +++ b/kernel/CompiledBlk.st
> > @@ -217,7 +217,7 @@ CompiledCode subclass: CompiledBlock [
> >
> > <category: 'printing'>
> > aStream
> > - nextPutAll: '[] in ';
> > + nextPutAll: '[%1] in ' % {self hash};
> > print: method
> > ]
>
> irrelevant?
Not when seperateBlocks is true. I need the block to appear differently from
another block in the same method.
>
>
> > + profilerOn [
> > + "Turn on the profiler"
> > +
> > + <category: 'profiling'>
> > + <primitive: VMpr_SystemDictionary_profilerOn>
> > + ]
>
> Can you pass the IdentityDictionary object here instead of creating it
> in _gst_reset_profiler
I think a common usage is to turn on/off the profiler multiple times to skip
the uninteresting part of the program to keep the profile uncluttered so I want
the raw profile to be persistant. Also the raw profile is a MethodDictionary
not an IdentityDictionary.
>
> > + _gst_identity_dictionary_at_inc(profile, _gst_true_oop,
> > + _gst_bytecode_counter);
> > + _gst_bytecode_counter = 0;
>
> Here can you save the bytecode counter and add the delta?
I can. I didn't find other use of the counter that is relevant when profiler is
on though.
Derek