[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: acl for cvs, access from internal machines

From: Edward Peschko
Subject: Re: acl for cvs, access from internal machines
Date: Thu, 26 Jun 2003 18:48:15 -0700
User-agent: Mutt/1.3.22i

> It is the right forum, (I actually have your message in a queue of
> things to look at right behind a patch by Dieter Mauer that deals with
> keyword substitution, but which turned up an odd problem that I have
> been trying to track down in that his keyword2-20k test does something
> odd).

> We are NOT YET at the point where we have moved to using full ANSI C
> specifications as we are still conformant to being used by K&R C
> compilers. It has been discussed, but it is not yet adopted.

ok... I used gcc-2.95.3 as a back-check (as well 
as /opt/SUNWspro/bin/cc) do you have a K&R compiler I could
check it out on?

> Additionally, the fact that the _printit function is an illegal name
> (functions with leading underscores are reserved). The intent is to have
> source code that can get through all of the compilers for the platforms
> that presently 'support' cvs on them... the entire world does not yet
> use an ANSI C compiler.

the _printit function was a debugging function that I forgot to remove.

> Other formatting problems include calls to functions like xmalloc have
> the space before the opening parenthesis and not after it. For example:
>       /* some comment about the magic number 4 being used on the next line */
>       fullpath = xmalloc (strlen(dir) + strlen(file) + 4);
> (your comment is missing in at least one place).

the 'magic number 4' is a bit of sloppiness on my part. Its the one at 
which purify stopped complaining.. :->

No, actually I don't know what prompted me to choose 4, other than
it was 2:30 in the morning...

> Many function calls are missing the space before the parenthesis entirely.
> Some lines are a lot longer than eighty columns without a real need for
> them to be.

That's my fault, my environment has exceedingly small type, and is 
greater than 80 characters because I do a lot of data work. Maybe
I should have a devel window and a work window - except that I'm
on windows 2000, using 'screen' to a solaris workstation, and hence
don't have virtual desktops. :-<
> You also have not provided ChangeLog entires that describe what has
> changed.

true, true. like I said, the main point of the patch was to float out
an idea (albeit a *usable* idea ) and work on the niceties later. 
Considering I didn't know what the niceties were...

> I don't know about the rest of the team, but I have lots of things that
> are happening, so I just have not had time to really look at the patch.
> To be honest, I'll be on holiday for a few weeks in July, so I probably
> will not be getting to even looking closely at your patch until August
> (I just do this cvs work as a hobby).

thats fine with me.. I can still use my patch, and others can do
the same if they like.. 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]