[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libcdio-devel] RFC: Savannah issue bug #35745
From: |
Rocky Bernstein |
Subject: |
Re: [Libcdio-devel] RFC: Savannah issue bug #35745 |
Date: |
Tue, 13 Mar 2012 10:14:57 -0400 |
On Mon, Mar 12, 2012 at 8:00 AM, Robert William Fuller <
address@hidden> wrote:
> On 03/12/2012 05:09 AM, Nicolas Boullis wrote:
> > On Sun, Mar 11, 2012 at 11:09:35PM -0400, Rocky Bernstein wrote:
> >> A patch was recently submitted: https://savannah.gnu.org/bugs/?35745
> >>
> >> Any comments on this?
> >
> > I had no idea that identifiers that begin with _[_A-Z] were reserved,
> > but if they really are, I think it is sane to replace them, at least for
> > macros use as "header guards", which, I guess, nobody uses outside the
> > header files themselves.
> > As for the patch itself, it adds a 32-character random-like suffix to
> > all identifiers. I think this is really ugly, and I can see no good
> > reason for this...
>
> I agree with the comment that this is ugly. Also, somebody might have
> code that looks something like this, not that it cannot be changed:
>
> #ifndef __CDIO_H__
>
> struct msf_s {
>
> uint8_t m;
> uint8_t s;
> uint8_t f;
> };
>
> #endif // __CDIO_H__
>
> Rob
>
>
Ok. Thanks for pointing out. We'll make sure to keep this the same.