Re: [libmicrohttpd] Remove PlibC from autotools files

[Christian Grothoff]

On 08/07/13 18:24, Michael Cronenworth wrote:
> On 08/07/2013 09:32 AM, Christian Grothoff wrote:
> > Ah, but that itself doesn't require the 'select' on pipes.  Could you please try
> > to run the full test suite ("make check")?
>
> I wasn't sure if my patches would be accepted (or reviewed this quickly). After
> running make check I had to make one small tweak[1] to pipe handling. The test
> cases also needed their old macros to be replaced[2] with native calls. The
> test_quiesce case uses fork, which doesn't have an easy replacement.The test
> would need to be reworked to use Windows threads, but I'm not interested in
> doing this.

If you look at SVN HEAD, that test is already disabled for W32 as it 
doesn't work there.

> The MHD test suite passes (log attached). The testcurl tests mostly failed, but
> it references errors trying to open a port so this may be an issue with Wine (I
> compile on Fedora).

That's odd, are you running any other services that use the ports used 
by the testcases?

> [1] libmicrohttpd-mingw-pipe.patch
>      Use ReadFile/WriteFile for sending pipe messages. Add debug output if
>      looking at the pipe fails.

LRN/ndurner: what do you think about this?

-Christian

> [2] libmicrohttpd-mingw-tests.patch
>      Replace PlibC macros with native calls.
>      Does not run test_quiesce on Windows builds - uses fork().