Re: [libmicrohttpd] suspend/resume patch

[Christian Grothoff]

Dear Jose,

In SVN HEAD, I've started to implement *full* and proper support for
HTTP Upgrade.  Hence, the best way to get this moving is to:

(1) make sure you work on SVN HEAD and not 0.9.49, and
(2) provide concrete executable testcases that demonstrate
    that your changes fix something.

I would really appreciate the latter, especially as extensive testing is
exactly what I'll have to do before this can become release-ready.

I'll still look at your patch a bit more next time I can hack on this;
however, given that you're not providing me with concrete scenarios
where this fixes something, it's a bit hard for me to reverse-engineer
the motivations for the patch.

Thanks & Happy hacking!

Christian


On 08/29/2016 11:06 PM, José Bollo wrote:
> Le jeudi 04 août 2016 à 21:29 +0200, Christian Grothoff a écrit :
>> Hi Jose,
>>
>> You've not been forgotten, I'm thinking about it and trying to find
>> the
>> time to really do the right thing here...
>>
>> Best,
>>
>> Christian
>>
> 
> Salut Christian,
> 
> This day I realized that my patch was really bad. I changed it with
> success to a new version that I submit to your best wishes. It applies
> on 0.9.49 that is not very far. See the attachment. I think that you
> will easily understand the difference between:
>  1- is it possible to add a keep-alive value to the header connection?
>  2- should the connection be close (or conversely should it be kept
> alive)
> 
> Best regards.
> José Bollo
>

0xE29FC3CC.asc
Description: application/pgp-keys

signature.asc
Description: OpenPGP digital signature