[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libredwg] GSoC coding starts

From: Felipe Castro
Subject: Re: [libredwg] GSoC coding starts
Date: Sun, 18 Aug 2013 14:12:44 -0300


Have you seen the patch I sent to Savannah? Maybe useful for you, I just added a "dump" program in the examples dir, but there were some side effects in the src dir, sorry.

Not hoping to be direct patched, but you may see the side effects as more suggestions in your refactoring, ok? Here is a summary:

1 - move Bit_Chain from bits.h to dwg.h (eliminating duplication with Dwg_Chain)

2 - apply LOG_ERROR to "crc todo" messages (many places)

3 - move version_codes[8][7] global variable from commo.c to dwg.c (make it accessible with an api function)

4 - move Dwg_Version_Type from common.h to dwg.h (maybe useful for the library user)

5 - remove Dwg_Data_Type and dwg_var_map from common.h (they are obsolete, heritage from LibDWG).

6 - remove "if (0)" non-reachable code from dwg.spec (that's ugly)

7 - isolate "encode/decode_3dsolid" functions in dwg.spec. My fault: instead of "#ifdef IS_PRINT" edit to "#ifndef IS_PRINT" (not sure if really useful, but it was necessary for me to reuse "dwg.spec" from the new dump program)

Kind regards,
Felipe Castro.

2013/8/13 Avneet Kaur <address@hidden>
On Tue, Aug 13, 2013 at 7:21 PM, .Org.Com <address@hidden> wrote:
>> Keep your daily diary updated. Show your progress and discuss more on
>> mailing list.
> Are you there?

Hello !

Currently I am working on adding R2007 support for decoding. Will show
code soon.

Er. Avneet Kaur

"Coming together is a beginning; keeping together is progress; working
together is success."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]