[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch 15/19] 299-gary-refactor-autotests.diff Queue

From: Gary V. Vaughan
Subject: Re: [patch 15/19] 299-gary-refactor-autotests.diff Queue
Date: Mon, 10 Oct 2005 16:46:34 +0100
User-agent: Mozilla Thunderbird 1.0 (X11/20050305)

Ralf Wildenhues wrote:
Hi Gary,

Hallo Ralf,

Approved (after its requirements are in, if any), except for one nit,
see below inline.

Okay, thanks.

Oh, if you were bored, you could
but really I don't care.

Okay, I've made it into _LTDL_PROJECT_FILES([LDTL-DIR])

-LT_AT_LIBTOOLIZE([--copy --ltdl])
+LT_AT_LIBTOOLIZE([--copy --ltdl=sub/ltdl])

Why did you change `--ltdl' to `--ltdl=sub/ltdl' here?
IMO better to leave as-is, unless there is a compelling reason against
it.  (We have to support plain `--ltdl' for backward compatibility.)

Because the Makefile in _LTDL_PROJECT_FILES used to hardcode
sub/ltdl.  Now fixed.

Gary V. Vaughan      ())_.  address@hidden,}
Research Scientist   ( '/
GNU Hacker           / )=
Technical Author   `(_~)_

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]