[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch 01/19] 277-gary-rename-remaining-troublesome-ltdl-apis.diff Q

From: Gary V. Vaughan
Subject: Re: [patch 01/19] 277-gary-rename-remaining-troublesome-ltdl-apis.diff Queue
Date: Tue, 25 Oct 2005 09:36:00 +0100
User-agent: Mozilla Thunderbird 1.0 (X11/20050305)

Ralf Wildenhues wrote:
Hi Gary,

Hallo Ralf,

Thanks for the review!

* Gary V. Vaughan wrote on Mon, Oct 10, 2005 at 12:26:25PM CEST:
Index: libtool--devo--1.0/ChangeLog
from  Gary V. Vaughan  <address@hidden>
        * libltdl/ltdl.h, libltdl/ltdl.c (lt_dlhandle_first): Removed.
        * libltdl/ltdl.h, libltdl/ltdl.c (lt_dlhandle_next)
        (lt_dlhandle_find, lt_dlforeach): Removed...
        (lt_dlhandle_iterate, lt_dlhandle_fetch, lt_dlhandle_map): Similar
        functions that are multi-loader safe, and require a registered
        interface validator argument.
        * doc/libtool.texi: Updated.
        * NEWS: Updated.
OK to apply, with the nits below addressed.

Okay.  I've addressed all the nits you found.  Thanks for being so

Please also apply the then-freed part of your patch queue,

Before 277, I have (see my patch queue status mail from last Tue):

- patches/302-gary-libtoolize-config.diff
  review pending

that should 284, 285, 286 I believe;

After 302 is cleared to apply, that will unblock 277, 284 and 285.
286 will then still be blocked by:

+ patches/303-gary-correct-included-file-matching-expression.diff
  review pending

with 286, please just
take one look at the additional tiny nit I found, see other mail.

Will do.

I might be able to apply the patches out of order, but I don't trust
myself to do a careful enough interdependency analysis --  plus I
already did extensive testing in the order they are queued, and it
seems like unnecessary additional work to retest everything after
twiddling the order when we need them all to go in to fix outstanding
known bugs in HEAD anyway.  Hope that isn't too much of a pain for

Thank you!

Likewise.  :-D

Gary V. Vaughan      ())_.  address@hidden,}
Research Scientist   ( '/
GNU Hacker           / )=
Technical Author   `(_~)_

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]