libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 326-gary-remove-stamp-vcl


From: Ralf Wildenhues
Subject: Re: 326-gary-remove-stamp-vcl
Date: Mon, 26 Mar 2007 20:13:07 +0200
User-agent: Mutt/1.5.14 (2007-03-22)

Hi Gary,

* Gary V. Vaughan wrote on Mon, Mar 26, 2007 at 07:10:21PM CEST:
> 
> Tested with vendor make on OSF/1 5.1, AIX 5.2, IRIX 6.5, HPUX 10.20
> and Solaris 10.  Apart from IRIX, VPATH builds also work from a fresh
> dist tarball on the other architectures -- to my surprise!  I've also
> successfully completed a full test run for a VPATH and in-tree build
> on Linux, so there are no regressions.

Thank you, for all the work on this!

> Okay to commit to HEAD?

I see one smallish issue and a couple of nits: First, now whenever
ChangeLog is touched, the configure recheck will be triggered.  This
isn't a biggie, and if we don't see a simple way around it, then it
should just stay as it is.  (I think this was the reason the stamp file
was originally invented for anyway.)  Second, can we remove the `$target
is up to date' output for all thingies?  Please also update NEWS to
reflect this change.

Thanks again,
Ralf

>   Index: ChangeLog
>   from  Gary V. Vaughan  <address@hidden>
>       The stamp-vcl file rules caused non-gnu make programs to rerun
>       parts of the configuration process on each invocation.  Instead
>       of relying on a stamp file, we now compare version numbers of
>       generated files with the ChangeLog timestamp manually in the
>       affected make rules to decide whether regenerating is necessary:
> 
>       * Makefile.am (EXTRA_DIST): Remove stamp-vcl.
>       (clean-ltmain-sh): Also remove users' obsolescent stamp-vcl.
>       (rebuild): Keep some common code here for...
>       (libtool, libltdl/m4/ltversion.m4, libltdl/config/ltmain.sh):
>       Rewritten to work without reference to intermediate stamp-vcl
>       file.
>       * configure.ac (CONFIG_STATUS_DEPENDENCIES): Change from
>       stamp-vcl to ChangeLog.
[...]

>   +   else \
>   +     echo \`$$target\' is up to date; \




reply via email to

[Prev in Thread] Current Thread [Next in Thread]