[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes

From: Paolo Bonzini
Subject: Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes
Date: Mon, 26 Jul 2010 16:04:47 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5

On 07/26/2010 01:57 PM, Charles Wilson wrote:
These are rebased versions of Paolo's sysroot patches, rebased to
0e01d00c70fe1eba2b746a6bb52e3c9277a4f1ef (Sun Jul 18 17:17:15 2010 +0200)

As it happens, Paolo's old 3/8 'provide shell functions to configure.patch' 
apply very well at all, given the recent changes.  So, I took the brute force
approach with 9/9 in this series: 'Configure script should not use libtool-only
shell functions'

Same as what I did.

The end result is that the .la file when a library is built cross contains
stuff like this:
# Libraries that this one depends upon.
dependency_libs=' =/mingw/lib/ =/mingw/lib/'
# Directory that this library needs to be installed in:

Thanks for figuring out all that instead of waiting for me to explain it. :(

The new libtool knows how to interpret the '=' when using a sys-root (e.g.
a cross compiler).  I haven't yet tested how a NATIVE compiler/libtool
reacts when you try to link against an .la file that was created elsewhere
using a cross compiler/libtool combo. First things first:

It should work, lt_sysroot will be empty.

The C++ problem is basically that the postdeps don't get populated properly.

That's the only part of libtool.m4 that the patches touch, so either patch 9/9 has a stupid typo somewhere (in which case testing the first eight patches would pass the tests), or patch 2/9 is introducing a bug instead of fixing it.

Thanks again!

BTW, feel free to squash your changes with mine in subsequent submissions, no matter what git does with attribution, so that the history stays bisectable.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]