lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Tablatures and beams


From: Erlend Aasland
Subject: Re: [PATCH] Tablatures and beams
Date: Tue, 11 Jan 2005 01:11:41 +0100

> > fret numbers on string. I've tried several font sizes and it seems to
> > work perfect.
> Good; but I'm not satisfied yet.
Hmmm, me neither: Stems pointing upwards collide with the fret
numbers. I've grepped around a bit and found the
tablature-stem-attachment-function, but it does not help much. I'll
look into it some more and try to come up with a better patch.

> Your function is partially
> duplicating Staff_symbol_referencer::callback(), and duplication is
> bad. Also, the 0.65 seems rather arbitrary to me; can you explain
> where this number is coming from?
Stole it from the old extra-offset in TabNoteHead (scm/define-grobs.scm)

> If we're leaving the arbitrary offset there, we could just as well
> do
> 
>    (Y-offset-callback . (,(lambda (g a) -0.65)
>                          ,Staff_symbol_referencer::callback ))
Yeah, that would be a better solution.

> > Perhaps we should have a pair of functions to ease choosing between
> > printing on/above strings? Maybe \printFretNr{On|Above}Strings? 
> I thought that On Strings was the standard? Why do we want the switch?
Well, 90% of the tabs I've seen print on strings, but some old banjo
books print above strings. Maybe we should just stick with whats
common and print on strings.

> 
> --
> 
>  Han-Wen Nienhuys   |   address@hidden   |   http://www.xs4all.nl/~hanwen
> 
>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]