lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lilypond lily/context.cc lily/context-def.cc li...


From: Han-Wen Nienhuys
Subject: Re: lilypond lily/context.cc lily/context-def.cc li...
Date: Tue, 16 May 2006 14:36:15 +0200
User-agent: Thunderbird 1.5.0.2 (X11/20060501)

Erik Sandberg schreef:
+  // TODO: The above operations should be performed by a listener to the 
following event.
+  send_stream_event (this, "CreateContext",
+                     ly_symbol2scm ("unique"), scm_int2num (unique),
+                     ly_symbol2scm ("ops"), ops,
+                     ly_symbol2scm ("type"), cdef->get_context_name (),
+                     ly_symbol2scm ("id"), scm_makfrom0str (id.c_str ()));

+void
+Context::internal_send_stream_event (SCM type, SCM props[])
+{
+  Stream_event *e = new Stream_event (this, type);
+  for (int i = 0; props[i]; i++)
+  {
+    assert(props[i+1]);
+    e->internal_set_property (props[i], props[i+1]);
+  }

How is this possible? I thought I asked to test "make web" before committing? This doubly wrong: the increment should be 2, and there is no trailing NULL in the call.

Also, please use GNU coding standards for indenting blocks.

--

Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]