[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dumb stacking page breaker

From: Nicolas Sceaux
Subject: Re: dumb stacking page breaker
Date: Fri, 13 Jul 2007 23:46:21 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (darwin)

Joe Neeman <address@hidden> writes:

> The basic idea behind the inheritance in the page-breakers is that [...]

I had the feeling of doing something not really conforming to your
design :-) Thanks for the suggestions, I'll work in that direction.

> The looping logic in compute_page_breaks seems to me more convoluted
> than that in Page_breaking::min_page_count.  As far as I can tell,
> though, they do exactly the same thing. Could you change the looping
> logic to match min_page_count?

OK. (silly me, I had not realized that min_page_count did that...)

> Also note that your last "for" loop is unnecessary. As per 
> the comment in min_page_count, you can do
> if (things don't fit on the last page)
> {
>   systems_per_page.back ()--;
>   systems_per_page.push_back (1);
> }

Indeed, I realized that the next day, when thinking about this patch
while driving my family to our vacation place (don't other geeks think
about hacking during long travels?)

> +  /* what is the purpose of cached_configuration_index_? it is never set,
> +     save in clear_line_details_cache -- ns */
> Good point, it should be set in the following lines after the comment:
> if (cached_configuration_index_ != configuration_index)
>   {
>     cached_configuration_index_ = configuration_index;
>     ...

That's what I thought, but I wanted to be sure.

Thank you very much


reply via email to

[Prev in Thread] Current Thread [Next in Thread]