[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Fix 524 (pitched trill accidental forgetfulness)
From: |
Neil Puttock |
Subject: |
[PATCH] Fix 524 (pitched trill accidental forgetfulness) |
Date: |
Wed, 11 Jun 2008 02:42:01 +0100 |
Hi everybody,
Attached is the gist of a patch detailing a fix for Issue 524. Could
someone check it for me or suggest any improvements so I can push with
an updated regtest?
There are two things which I'm concerned about:
- it copies some code from accidental-engraver.cc to get the current
bar number, so I was wondering whether there might be a more efficient
way for both engravers to get this information (perhaps a Scheme proc
call?)
- make_trill should read force-accidental, so that forced accidentals
can be set using "!" instead of the workaround \once \set
localKeySignature = #'(). Whilst it's trivial to test for
force-accidental in the engraver, I'm stumped when it comes to
transferring the property as part of the trill-span-events in the
pitchedTrill music function.
As an aside, while working on this fix, I noticed that the description
for localKeySignature is ambiguous: it says that the property is reset
at a bar line. As far as I can tell, it only gets reset when there's a
new key signature.
Regards,
Neil
0001-Fix-524-pitched-trill-losing-accidental.patch
Description: Text Data
- [PATCH] Fix 524 (pitched trill accidental forgetfulness),
Neil Puttock <=