[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)
From: |
Han-Wen Nienhuys |
Subject: |
Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness) |
Date: |
Wed, 11 Jun 2008 23:49:54 -0300 |
On Wed, Jun 11, 2008 at 3:55 AM, Mats Bengtsson
<address@hidden> wrote:
> Neil Puttock wrote:
>
>> As an aside, while working on this fix, I noticed that the description
>> for localKeySignature is ambiguous: it says that the property is reset
>> at a bar line. As far as I can tell, it only gets reset when there's a
>> new key signature.
>>
>
> If you manage to digest all the code related to autoAccidentals,
> I'm sure you will sooner or later discover that localKeySignature
> indeed is reset every bar line, at least if you have the default
> settings for autoAccidentals.
>
that doesn't make sense: for various accidental styles, a reminder may
need to be printed more than one measure after the last alterated
note. As far as I can see, the localKeySig keeps the last alteration
for a given pitch indefinitely, until the next alteration of that
pitch is seen. This is what happens in
Accidental_engraver::stop_translation_timestep ().
--
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen