[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: Raised 6th step in figured bass

From: Han-Wen Nienhuys
Subject: Re: [PATCH] Re: Raised 6th step in figured bass
Date: Fri, 13 Jun 2008 02:22:29 -0300

Looks good to me. Just for clarity, it seems you have a generic
function to draw the line, and a number of exceptions.  Can you show
both (exception vs. default) of them in the test (which should be in
input/regression if it is not already), so we can see where you have
to hardcode the exceptions?


On Thu, Jun 12, 2008 at 2:59 PM, Reinhold Kainhofer
<address@hidden> wrote:
> Am Mittwoch, 11. Juni 2008 schrieb Reinhold Kainhofer:
>> Am Mittwoch, 11. Juni 2008 schrieben Sie:
>> > 2008/6/10 Reinhold Kainhofer <address@hidden>:
>> > > The corresponding markup function is \backslashed-digit:
>> > >     \markup {\backslashed-digit #6 }
>> >
>> > Thanks for adding a snippet to this; if it gets approved, you've saved
>> > me a bit of work. ;)
>> >
>> > The only problem I can see is the duplication between the two markup
>> > commands. Wouldn't it be preferable for there to be one utility
>> > function which combines the code for both slash directions, with a
>> > flag option for switching between the two? Then each markup command
>> > would simply call this utility function instead
>> I don't know. The structure of both is similar, but they use a different
>> slope and different special cases (moving the slash up/down for some
>> numbers to make it look better)... It probably won't save much code, but
>> might make it more maintainable. I'll have a look.
> Okay, here is an updated patch, where I combine the functionality into one
> internal function (I still have two markup functions, \slashed-digit and
> \backslashed-digit, which both call the internal scheme function
> slashed-digit-internal).
> I also increased the slope of the forward slashes to make it easier to
> distinguish forward and backward slashes. For some numbers, I also enlage the
> X extent of the slash so that its overshoot over the number itself is better
> visible. Patch and an example to see the new look is attached.
> Okay to apply?
> Cheers,
> Reinhold
> PS: The only slashed digit I have encountered in my hand-engraved scores
> appears to be a backslashed 6, so this is probably the most important digit
> to look right.
> --
> ------------------------------------------------------------------
> Reinhold Kainhofer, Vienna University of Technology, Austria
> email: address@hidden,
>  * Financial and Actuarial Mathematics, TU Wien,
>  * K Desktop Environment,, KOrganizer maintainer
>  * Chorvereinigung "Jung-Wien",
> _______________________________________________
> lilypond-devel mailing list
> address@hidden

Han-Wen Nienhuys - address@hidden -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]