[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: fret diagram comments

From: Carl D. Sorensen
Subject: RE: fret diagram comments
Date: Sun, 22 Jun 2008 06:51:21 -0600

> -----Original Message-----
> From: Han-Wen Nienhuys [mailto:address@hidden
> Sent: Sunday, June 22, 2008 5:31 AM
> To: Carl D. Sorensen
> Cc: lily-devel
> Subject: Re: fret diagram comments
> On Sun, Jun 22, 2008 at 5:07 AM, Carl D. Sorensen
> <address@hidden> wrote:
> > I will be happy to clean up the formatting.  I can see that
> the code
> > lines are too long, which give lots of random wraps and
> hides the structure.
> >
> > Of course, when I do this, the diff will be twice as large
> as the file.  Are you OK with that?
> Sure, but it is good practice to not mix the formatting
> cleanups and functional cleanups in the same code.

OK.  So right now I have some functionally changed code  with ugly formatting
that passes the regression test.  Would you prefer to:

1) Pull a patch  on the ugly code, then have me fix the formatting an pull 
another patch

2) Have me fix the formatting on the original code (as is currently in 
  pull a patch, and then have me redo the revised functionality (I don't think I
  can do this well with git diifs; I think I'll have to manually re-enter the
  code changes)

3) Have me fix the formatting on the working code and verify that it works with 
  regression test, and then you can pull the working, formatted code (but this 
  not be good practice, as it mixes formatting cleanups and functional changes)

4) Do something else that I haven't thought of



reply via email to

[Prev in Thread] Current Thread [Next in Thread]